Please make generated __init__.py files reproduducible #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the "reproducible builds" effort [0], we noticed that genpy generates output with a non-determistic order. The attached patch removes this randomness from the build system. Once applied, packages using python-genpy can be built reproducibly using our reproducible toolchain. [0] https://wiki.debian.org/ReproducibleBuilds Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
|
It is already our goal to keep the build results deterministic. Thank you for the patch. |
dirk-thomas
added a commit
that referenced
this pull request
Feb 22, 2016
Please make generated __init__.py files reproduducible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the "reproducible builds" effort [0], we noticed that
genpy generates output with a non-determistic order.
The attached patch removes this randomness from the build system. Once
applied, packages using python-genpy can be built reproducibly using our
reproducible toolchain.
[0] https://wiki.debian.org/ReproducibleBuilds
Signed-off-by: Chris Lamb chris@chris-lamb.co.uk