Allow durations to be divided by other durations #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the docblocks to clarify that duration arguments are also supported. |
| @@ -398,6 +398,8 @@ def __floordiv__(self, val): | |||
| return Duration(self.secs // val, self.nsecs // val) | |||
| elif t == float: | |||
| return Duration.from_sec(self.to_sec() // val) | |||
| elif isinstance(val, Duration): | |||
| return self.to_sec() // val.to_sec() | |||
There was a problem hiding this comment.
Note that unlike everything else mentioned in #49, Duration // Duration is meaningful
|
Docblocks are done - would you prefer I squash this? |
|
Yes, please squash. |
For instance `Duration(secs=10) / Duration(secs=5) == 2` Update docstrings
|
(squashed) |
|
ICYMI, github now can squash PRs when merging |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance
Duration(secs=10) / Duration(secs=5) == 2