Regression in msg_generator when escaping trailing double-quotes #51
Conversation
|
although, even Empty for me is giving full_text='\n'. But something else might show up (in light of 4f7755b#commitcomment-16880685) |
| @@ -772,7 +772,7 @@ def msg_generator(msg_context, spec, search_path): | |||
|
|
|||
| full_text = compute_full_text_escaped(msg_context, spec) | |||
| # escape trailing double-quote, unless already escaped, before wrapping in """ | |||
| if full_text[-1] == '"' and not full_text[-2:] == r'\"': | |||
| if len(full_text) > 0 and full_text[-1] == '"' and not full_text[-2:] == r'\"': | |||
There was a problem hiding this comment.
I thought about something similar yesterday 😉 but only tried it with a string of length 1 which the list slicing if obviously fine with...
Anyway I think we should make it even more simple and defensive now:
if full_text.endswith('"') and not full_text.endswith(r'\"'):
There was a problem hiding this comment.
Ah, I hadn't seen this before! will use it from now on, thanks
|
Adding checks for every std_msgs seems to be extensive. Especially since |
|
ok - here's hoping :) |
|
Great. Thanks! |
Does it make sense to add tests for genpy to check each of the std_msgs?