expose spec for dynamically generated messages #75
Conversation
|
@ros-pull-request-builder retest this please |
| @@ -190,6 +190,7 @@ def generate_dynamic(core_type, msg_cat): | |||
| messages[t] = getattr(mod, _gen_dyn_name(pkg, s_type)) | |||
| except AttributeError: | |||
| raise MsgGenerationException("cannot retrieve message class for %s/%s: %s"%(pkg, s_type, _gen_dyn_name(pkg, s_type))) | |||
| messages[t]._spec = specs[t] | |||
There was a problem hiding this comment.
could you point me to where the _spec slot/attribute is defined ? I can't find it in the generated python modules or the genpy.Message class. Is it equivalent to _full_text in the generated classes?
There was a problem hiding this comment.
The instance is a generated class. It doesn't have that attribute before. _full_text contains the plain text of the message, _spec contains the parsed MsgSpec instance for the message.
There was a problem hiding this comment.
ok that explains what I couldn't find it in the generated code then. Thanks for clarifying 👍
|
@ros/ros_team Please review. |
|
Isn't @mikaelarguedas already reviewing it? |
|
I am still waiting for an approval on this. |
Required for ros/ros_comm#1006.
@ros/ros_team Please review.