Make python scripts Python3 compatible. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ros-pull-request-builder retest this please. |
|
Is this test failure related to these changes? I don't see how the changes could affect the line that throws the error. |
|
Thanks for the patches! The test failures are due to a required coordinated release between geometry2 and geometry. The current branch requires the unreleased version of geometry2. (It's out on lunar which is why it passes there. But the others are queued. |
|
thanks :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically #67 but rebased on indigo-devel. Also, since 707eb41 removed
pytf.cpp, everything touching that is gone. That should make it much easier to merge this.I squashed the original python fixes by @pallegro and added a few more in a second commit.