Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openni2 can be removed #8

Closed
hgaiser opened this issue Apr 1, 2015 · 6 comments
Closed

openni2 can be removed #8

hgaiser opened this issue Apr 1, 2015 · 6 comments

Comments

@hgaiser
Copy link

hgaiser commented Apr 1, 2015

The openni2 formula can be removed, as it is outdated and https://github.com/Homebrew/homebrew-science/blob/master/openni2.rb works fine.

@wjwwood
Copy link
Member

wjwwood commented Apr 2, 2015

@hgaiser thanks for the heads up, I'll remove it.

@wjwwood wjwwood closed this as completed in 3d53132 Apr 2, 2015
@hgaiser
Copy link
Author

hgaiser commented Apr 9, 2015

Ah .. except they don't install a pkg-config file, causing openni2_camera to fail finding the library. Do you think it is best to upstream it to homebrew-science?

Correction: Is openni2_camera even supposed to compile on osx?

@wjwwood
Copy link
Member

wjwwood commented Apr 9, 2015

I have compiled and used it before. If the openni2 package upstream has a problem you should file an upstream issue. In the future please make sure the upstream package works before suggesting something like this. I don't always have time to completely test things and so I'm trusting you guys to have done your homework before getting here.

@hgaiser
Copy link
Author

hgaiser commented Apr 9, 2015

I know, and I usually do, however I was generally not using the openni2_camera package (I am using a different ros interface which did compile fine.. It didn't depend on cmake). I will see what I can do.

@wjwwood
Copy link
Member

wjwwood commented Apr 9, 2015

That's cool, just letting you know I depend on you guys so you don't take for granted that I'm testing this stuff all the time.

I will see what I can do.

Thanks.

@hgaiser
Copy link
Author

hgaiser commented Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants