Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle SIGINT #86

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Gracefully handle SIGINT #86

merged 1 commit into from
Dec 16, 2022

Conversation

zflat
Copy link

@zflat zflat commented Dec 16, 2022

Addresses #85 to graceful shutdown the python node after SIGINT.

@zflat zflat mentioned this pull request Dec 16, 2022
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@sloretz
Copy link
Contributor

sloretz commented Dec 16, 2022

CI (repos file build: --packages-up-to joint_state_publisher test: --packages-select joint_state_publisher)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Dec 16, 2022

Ah, this one isn't in ros2.repos. The green PR jobs is good enough then!

@sloretz sloretz merged commit 424fd9e into ros:ros2 Dec 16, 2022
@sloretz
Copy link
Contributor

sloretz commented Dec 16, 2022

Thank you for the PR!

@zflat zflat deleted the handle-sigint branch December 16, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants