Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apriltag patch does not work #1141

Open
mboel opened this issue May 3, 2024 · 2 comments
Open

Apriltag patch does not work #1141

mboel opened this issue May 3, 2024 · 2 comments

Comments

@mboel
Copy link

mboel commented May 3, 2024

I have an issue with the Apriltag package in the Kirkstone branch. The patch in apriltag_3.4.0-1.bbappend is not valid.
Removing the patch seems to fix the problem.

@robwoolley
Copy link
Collaborator

Thanks for reporting this. I tested with Kirkstone + Humble and reproduced the problem.

It looks like apriltag now has this line:
set(PY_DEST ${CMAKE_INSTALL_PREFIX}/lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}/site-packages/)

Which causes the patch to fail to apply. I may need to refresh the patch if the hardcoded path

@robwoolley
Copy link
Collaborator

I have submitted a fix for apriltag as part of the patch series I am working on. You can find the fix here: #1150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants