Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test laziness after disconnection #60

Merged
merged 1 commit into from
May 25, 2017
Merged

Test laziness after disconnection #60

merged 1 commit into from
May 25, 2017

Conversation

wkentaro
Copy link
Contributor

If lazy nodelet stopped being subscribed, it must stop subscribe its
input topics.

@wkentaro
Test laziness after disconnection
e6b8a9b 
If lazy nodelet stopped being subscribed, it must stop subscribe its
input topics.
mikaelarguedas
mikaelarguedas approved these changes May 25, 2017
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay, lgtm
We may need to revisit the arbitrary 1 second sleep if it starts being flaky on slow machines

@mikaelarguedas mikaelarguedas merged commit da9f64d into ros:indigo-devel May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkentaro @mikaelarguedas