Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to disable deprecation warnings. #17

Closed
ahendrix opened this issue Jul 16, 2013 · 2 comments
Closed

Provide a way to disable deprecation warnings. #17

ahendrix opened this issue Jul 16, 2013 · 2 comments
Labels

Comments

@ahendrix
Copy link

I have a couple of classes where the exported plugin name cannot be equal to the class name.

https://github.com/PR2/pr2_ethercat_drivers/blob/hydro-devel/ethercat_hardware/src/wg014.cpp

The exported plugin is a driver for a specific model of device, and the exported name is the model number of the device. This means that the top-level node can find drivers for a particular device by querying the device model number and then searching for a plugin with the same name.

@dirk-thomas
Copy link
Member

You should just upgrade to the new macro as suggested in the deprecation warning.

If you take a look at the implementation of the deprecated macro PLUGINLIB_DECLARE_CLASS you will see that the additional arguments which are dropped from the signature of the replacement macro are not even passed on the to lower level class_loader API.

@mirzashah
Copy link
Member

Yes, the XML file containing your plugin info is where the exported name is set -- previously this was set both in the XML file as well as the macro. This is now optional in pluginlib as of groovy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants