Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated headers. #217

Merged
merged 1 commit into from May 24, 2021
Merged

Conversation

clalancette
Copy link

They have been deprecated since 2017, so I think it is long
past time to remove them.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

They have been deprecated since 2017, so I think it is long
past time to remove them.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some warnings in MacOS. https://ci.ros2.org/job/ci_osx/12336/clang/new/.

@clalancette
Copy link
Author

There are some warnings in MacOS. https://ci.ros2.org/job/ci_osx/12336/clang/new/.

Ah yeah, those are unrelated and are fixed by ros-perception/image_common#192

@clalancette clalancette merged commit e7a8f53 into ros2 May 24, 2021
@clalancette clalancette deleted the clalancette/remove-deprecated-header branch May 24, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants