Catch ament_index_cpp::PackageNotFoundError #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
What does it do if you give it a |
Just logs a different message |
|
But in that case the package does exist? |
|
CI (testing just resource retriever)
|
In that case the package doesn't exist because I didn't source my tb3 workspace. Here's the collada case again with a different package name. |
|
What happens if the |
It works 🤷♂️. Like you say, no clue how it found the package.
<?xml version="1.0" ?>
<robot name="some">
<link name="base_link">
<visual>
<geometry>
<mesh filename="package://some_desc/meshes/backpack.dae"/>
</geometry>
</visual>
</link>
</robot> |
|
Weird, maybe it could use more investigation, but it seems like the current behavior is ok for both, even if we don't understand it at the moment. |
sloretz
added a commit
that referenced
this pull request
Nov 21, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Nov 21, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
This was referenced Nov 21, 2019
sloretz
added a commit
that referenced
this pull request
Dec 5, 2019
sloretz
added a commit
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash in rviz2. It should probably be backported to dashing and eloquent, though I've only tested on the latest ROS 2 sources.
To reproduce:
Save the following as
pkg_dne.urdfPublish it using
robot_state_publisherros2 run robot_state_publisher robot_state_publisher pkg_dne.urdfLaunch rviz2 and add a
RobotModeldisplay. Tell the display to use the description topic/robot_description. RViz will immediately crash.With this PR, RViz will log errors but continue to run
Side note, RViz only crashes if the mesh type is
stl. If I change it todaethen RViz does not crash, even without this PR. I don't know the reason for the difference. @wjwwood is this difference unexpected or something that should be looked at?