Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update curl reference from 7.57 to 7.58 #36

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Update curl reference from 7.57 to 7.58 #36

merged 1 commit into from
Feb 3, 2020

Conversation

nbbrooks
Copy link

@nbbrooks nbbrooks commented Feb 3, 2020

Pulls in curl fix curl/curl#2154 to fix resource retrieval in Windows

@nbbrooks
Update curl reference from 7.57 to 7.58
e54a3f0 
Pulls in curl fix curl/curl#2154 to fix resource retrieval in Windows
@nbbrooks
Copy link
Author

nbbrooks commented Feb 3, 2020

Windows Rviz error message with curl version <7.58 for retrieving a resource such as
package://my_package/meshes/actuator.stl

[rviz2.EXE-3] [ERROR] [rviz2]: Error retrieving file [file://C:\dev\ros2_example_ws\install\my_package/share/my_package/meshes/actuator.stl]: Invalid file://hostname/, expected localhost or 127.0.0.1 or none

@nbbrooks nbbrooks requested a review from wjwwood February 3, 2020 21:41
@nbbrooks nbbrooks mentioned this pull request Feb 3, 2020
Closed
wjwwood
wjwwood approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@wjwwood
Copy link
Member

wjwwood commented Feb 3, 2020

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@wjwwood
Copy link
Member

wjwwood commented Feb 3, 2020

macOS is having a bad day on our CI farm. I'll merge without and follow up if something shows up on nightly, but I think we don't use the vendor on macOS.

@wjwwood wjwwood merged commit 98a8791 into ros:ros2 Feb 3, 2020
tfoote referenced this pull request Feb 7, 2020
@nbbrooks
Update curl reference from 7.57 to 7.58
a42b138 
Pulls in this fix curl/curl#2154

Fixes resource retrieval in Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbbrooks @wjwwood