merge libcurl_vendor build instructions #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
clalancette
requested changes
Oct 18, 2022
clalancette
requested changes
Oct 19, 2022
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
|
Thanks! This is looking great to me now. I'm going to run a couple more tests on it locally. Assuming that is happy, I'll give this a run in CI. |
clalancette
approved these changes
Oct 19, 2022
|
CI:
|
|
All CI seems happy with this, so going ahead and merging. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested these changes on the galactic branch on ubuntu 18.04 and they worked fine. I'm not able to test them on windows or apple. I'm not a fan of pushing in
CMAKE_CXX_FLAGSlike I am, but am not sure how to otherwise do it.