This repository has been archived by the owner on Aug 3, 2020. It is now read-only.
Use signal and sys.exit to fix shutdown in joint_state_publisher #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes it works fine now ! Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vincentrou I think this fixes the shutdown problem. Feel free to take a look and test it. If you think it looks good I will close your PR in favor of this one.
(As a side note, I noticed while I was testing this that "Randomize" and "Center" buttons are just broken on Xenial/Qt5. I will take a look at that next.)
The solution is based on this Stack Overflow question:
http://stackoverflow.com/questions/2300401/qapplication-how-to-shutdown-gracefully-on-ctrl-c