This repository has been archived by the owner on Aug 3, 2020. It is now read-only.
Migrated slots in joint state publisher gui to Qt5 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a important fix; otherwise the publisher will crash. When will this get merged? Thanks! |
|
This fixes #172. 👍 Please review/merge this pull request as soon as possible! |
|
@isucan / @jacquelinekay can this be reviewed / merged quickly? This is an important bug fix. |
|
I'll try to get a release out this week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed one argument from the
updateSliders()slot. It is not needed in Qt5 and actually caused a type error:TypeError: updateSliders() takes exactly 2 arguments (1 given).