fix ros_location_find with Python 3 #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3, the
subprocess.Popen
has a text/non-text mode which decides the data type to use forcommunicate
.Source: https://docs.python.org/3.8/library/subprocess.html#subprocess.Popen.communicate
And without extra conversion, the
rosfindpath.py
will fail with the following trackback:This pull request is try to use
decode()
to convert it back tostr
to make it type correct.This fix was motivated by the issue reported here: ms-iot/ROSOnWindows#248