Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rostopic] Rostopic pub autocompletes the topic type #132

Conversation

Projects
None yet
3 participants
@javierdiazp
Copy link
Contributor

commented Dec 1, 2016

Despite the topic type being static, the autocomplete function (pressing TAB) doesn't provide it, but instead provides the whole list of types.

With this PR the autocomplete function uses the given topic name to search the corresponding type to autocomplete. If the topic wasn't declared beforehand, it provides the whole list as always.

Edited:
This solution has another implementation (#125). However, that solution uses awk to parse the topic information and that seems to be slower than this implementation because it only uses bash operations to do the parsing.

@jfabry

This comment has been minimized.

Copy link

commented Dec 1, 2016

This is joint work of Javier with @OmniSliver (credit where credit is due) as part of a course I am teaching at U. Chile. They have a blog about their work (in Spanish) here: https://javierdiazp.github.io/robotica2/

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Jan 25, 2017

This has already been implemented in #125 against the kinetic-devel branch. The feature might be considered for backporting before the next Jade / Indigo releases.

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Jan 25, 2017

Please consider to provide a PR against the kinetic-devel branch if you would like to propose a revised implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.