[rosbash] Add roscat to display file contents as stdout #99

wkentaro · 2015-12-21T06:08:05Z

In most of my cases, I don't want to edit file but just view.
That's why I'm adding this function, the candidates of names:

rosless
rosview

Upstream PR: ros/ros#99 Modified: - jsk_tools/env-hooks/99.jsk_tools.bash - jsk_tools/env-hooks/99.jsk_tools.zsh

tfoote · 2015-12-21T06:52:26Z

Starting with the simpler problem of just displaying the file might it be cleaner. Just implement roscat and then if you want to view it paginated you could do roscat foo bar | less or rosless could be implemented extending that capability.

wkentaro · 2015-12-21T06:55:01Z

That would be better 👍

wkentaro · 2015-12-21T07:13:36Z

I updated the commit.

tfoote · 2016-03-01T00:17:58Z

That looks a lot cleaner. @dirk-thomas it looks good to me but I haven't had a chance to test it.

dirk-thomas · 2016-03-01T00:33:27Z

I tried rosview rospy_tutorials listener in bash which didn't output anything. I also tried zsh with the command rosview rospy_tutorials listener which printed That file does not exist in that package.. So I don't think this is ready to be merged.

I also think rosview ... which simply does roscat ... | less is not necessary. We don't have to reinvent every command line tool to save the user to type a handful of letters on the console.

wkentaro · 2016-03-02T08:54:41Z

I fixed the code for rosbash.
Actually I cannot reproduce the problem on zsh.

Also should I remove roscat?

dirk-thomas · 2016-03-02T19:49:49Z

I would suggest to remove rosview. But lets see that others think, @ros/ros_team ?

tfoote · 2016-03-02T19:52:53Z

I think roscat is valuable, since there's no quick way to view files. But I agree that rosview seems redundant with roscat ... | less and is probably worth avoiding the extra complexity for future maintenance.

wjwwood · 2016-03-02T20:32:37Z

I'd give +1 to both commands. While I understand that rosview can easily be represented with an alias or simply typing roscat <args> | less and that there is some maintenance cost, I still think taking the contribution is fine.

dirk-thomas · 2016-03-02T23:14:56Z

I have tried roscat again and it works well when passing two argument in bash ans zsh (I haven't tested fish). But when calling roscat without arguments it prints Couldn't find package [] and also has a return code of zero. I think in that case it should print the usage as well as return 1 (since --help was not explicitly requested). Looking at the patch it seems to aim for that behavior but the condition is wrong.

Regarding rosless: please remove it from the PR since only one out of three reviews seems to be in favor.

Thank you for iterating on this!

wkentaro · 2016-03-02T23:47:17Z

Thanks, for the comments!
I have updated the commit. (removed rosview, added condition to show help when there're few arguments)

dirk-thomas · 2016-03-02T23:51:29Z

tools/rosbash/rosfish

@@ -279,6 +279,26 @@ function roscp
    cp $arg $argv[3]
 end

+function roscat
+    set -l arg
+    if test (count $argv) = 0


This condition hasn't been updated. Have you tried this case as it is? Does this work with fish?

Oops, I overlooked fish, will soon fix it.

2016年3月3日木曜日、Dirk Thomasnotifications@github.comさんは書きました:

In tools/rosbash/rosfish
#99 (comment):

@@ -279,6 +279,26 @@ function roscp
cp $arg $argv[3]
end

+function roscat

set -l arg

if test (count $argv) = 0

This condition hasn't been updated. Have you tried this case as it is?
Does this work with fish?

—
Reply to this email directly or view it on GitHub
https://github.com/ros/ros/pull/99/files#r54814099.

和田健太郎 / Kentaro Wada
http://wkentaro.com

wkentaro · 2016-03-03T00:41:57Z

I updated the commit, but cannot try to use on fish because I don't know how to use ros with fish. (there's no setup.fish, is it?)

dirk-thomas · 2016-03-03T00:53:35Z

You can just source the file you modified directly in a fish shell and should be able to use the commands defined in there.

wkentaro · 2016-03-03T01:15:41Z

There is the below error even if on jade-devel branch.

$ rosed rospy_tutorials listener
test: unexpected argument at index 2: '/opt/ros/indigo'
test: Expected a combining operator like '-a' at index 2
That file does not exist in that package.

dirk-thomas · 2016-03-03T17:15:31Z

Can you please look into a fix for this?

This should be backported to Indigo once it is merged.

wkentaro · 2016-03-04T10:44:07Z

hmm, I can't find how to fix it.
I'm not familiar with fish shell..

wkentaro · 2016-03-04T10:52:23Z

I removed the code for fish.
I can't believe the rosfish is working:

wkentaro@anaconda ~/r/i/s/r/r/t/rosbash> exec fish --login
wkentaro@anaconda ~/r/i/s/r/r/t/rosbash> . rosfish
complete: Too many arguments
/home/wkentaro/ros/indigo/src/ros/ros/tools/rosbash/rosfish (line 357): complete -x -c roscp -a '(_roscomplete_file)'et -x TEST works
                                                                        ^
in . (source) call of file “/home/wkentaro/ros/indigo/src/ros/ros/tools/rosbash/rosfish”,
    called on standard input,


       complete - edit command specific tab-completions

   Synopsis
       complete (-c|--command|-p|--path) COMMAND [(-s|--short-option)
       SHORT_OPTION] [(-l|--long-option|-o|--old-option) LONG_OPTION
       [(-a||--arguments) OPTION_ARGUMENTS] [(-d|--description) DESCRIPTION]

complete: Type “help complete” for related documentation

dirk-thomas · 2016-03-09T00:37:32Z

The return code still needs some work. When running e.g. roscat roscpp_tutorials and the usage is printed it should not have a return code of 0. Same for calling it with a not existing file as well calling roscat without arguments.

But calling roscat --help should return 0.

wkentaro · 2016-03-09T09:54:14Z

Thanks, I fixed it.

dirk-thomas · 2016-03-09T17:30:00Z

roscat roscpp_tutorials foo still returns 0.

wkentaro · 2016-03-09T17:42:13Z

I fixed it. Please review again.

On Thu, Mar 10, 2016 at 2:30 AM, Dirk Thomas notifications@github.com
wrote:

roscat roscpp_tutorials foo still returns 0.

—
Reply to this email directly or view it on GitHub
#99 (comment).

和田健太郎 / Kentaro Wada
http://wkentaro.com

dirk-thomas · 2016-03-09T17:56:42Z

That looks good now. Can you please squash the commits before the merge. Thank you!

wkentaro · 2016-03-09T17:58:13Z

Squashed.

[rosbash] Add rosview to show file contents

dirk-thomas · 2016-03-09T18:17:11Z

Cherry-picked to indigo-devel: 696efa7

wkentaro · 2016-03-09T18:33:58Z

Thanks.

wkentaro changed the title ~~[rosbash] Add rosless to view files with pager~~ [rosbash] Add rosview to view files with pager Dec 21, 2015

wkentaro force-pushed the add-rosless branch 2 times, most recently from e35ffbf to fc5d8dd Compare December 21, 2015 06:23

wkentaro added a commit to wkentaro/jsk_common that referenced this pull request Dec 21, 2015

[jsk_tools] Add rosview

175d216

Upstream PR: ros/ros#99 Modified: - jsk_tools/env-hooks/99.jsk_tools.bash - jsk_tools/env-hooks/99.jsk_tools.zsh

wkentaro mentioned this pull request Dec 21, 2015

[jsk_tools] Add rosview jsk-ros-pkg/jsk_common#1320

Merged

wkentaro force-pushed the add-rosless branch 2 times, most recently from 76035f9 to f5fcc9a Compare December 21, 2015 07:11

wkentaro force-pushed the add-rosless branch from f5fcc9a to e7971cd Compare December 21, 2015 07:14

wkentaro force-pushed the add-rosless branch 2 times, most recently from 85a240c to 33c0184 Compare March 2, 2016 23:46

dirk-thomas reviewed Mar 2, 2016
View reviewed changes

wkentaro changed the title ~~[rosbash] Add rosview to view files with pager~~ [rosbash] Add rosview to show file contents Mar 3, 2016

wkentaro force-pushed the add-rosless branch 2 times, most recently from e1b7ca5 to c19eb7a Compare March 4, 2016 10:50

dirk-thomas added the requires-changes label Mar 9, 2016

wkentaro force-pushed the add-rosless branch from d3f9c94 to a52564d Compare March 9, 2016 17:41

dirk-thomas removed the requires-changes label Mar 9, 2016

Add roscat to display file contents as stdout

3a0d4d1

wkentaro force-pushed the add-rosless branch from a52564d to 3a0d4d1 Compare March 9, 2016 17:57

dirk-thomas added a commit that referenced this pull request Mar 9, 2016

Merge pull request #99 from wkentaro/add-rosless

633ff6e

[rosbash] Add rosview to show file contents

dirk-thomas merged commit 633ff6e into ros:jade-devel Mar 9, 2016

dirk-thomas added the enhancement label Mar 9, 2016

wkentaro deleted the add-rosless branch March 9, 2016 18:33

wkentaro changed the title ~~[rosbash] Add rosview to show file contents~~ [rosbash] Add roscat to display file contents as stdout Mar 9, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rosbash] Add roscat to display file contents as stdout #99

[rosbash] Add roscat to display file contents as stdout #99

wkentaro commented Dec 21, 2015

tfoote commented Dec 21, 2015

wkentaro commented Dec 21, 2015

wkentaro commented Dec 21, 2015

tfoote commented Mar 1, 2016

dirk-thomas commented Mar 1, 2016

wkentaro commented Mar 2, 2016

dirk-thomas commented Mar 2, 2016

tfoote commented Mar 2, 2016

wjwwood commented Mar 2, 2016

dirk-thomas commented Mar 2, 2016

wkentaro commented Mar 2, 2016

dirk-thomas Mar 2, 2016

wkentaro Mar 3, 2016

wkentaro commented Mar 3, 2016

dirk-thomas commented Mar 3, 2016

wkentaro commented Mar 3, 2016

dirk-thomas commented Mar 3, 2016

wkentaro commented Mar 4, 2016

wkentaro commented Mar 4, 2016

dirk-thomas commented Mar 9, 2016

wkentaro commented Mar 9, 2016

dirk-thomas commented Mar 9, 2016

wkentaro commented Mar 9, 2016

dirk-thomas commented Mar 9, 2016

wkentaro commented Mar 9, 2016

dirk-thomas commented Mar 9, 2016

wkentaro commented Mar 9, 2016

[rosbash] Add roscat to display file contents as stdout #99

[rosbash] Add roscat to display file contents as stdout #99

Conversation

wkentaro commented Dec 21, 2015

tfoote commented Dec 21, 2015

wkentaro commented Dec 21, 2015

wkentaro commented Dec 21, 2015

tfoote commented Mar 1, 2016

dirk-thomas commented Mar 1, 2016

wkentaro commented Mar 2, 2016

dirk-thomas commented Mar 2, 2016

tfoote commented Mar 2, 2016

wjwwood commented Mar 2, 2016

dirk-thomas commented Mar 2, 2016

wkentaro commented Mar 2, 2016

dirk-thomas Mar 2, 2016

Choose a reason for hiding this comment

wkentaro Mar 3, 2016

Choose a reason for hiding this comment

wkentaro commented Mar 3, 2016

dirk-thomas commented Mar 3, 2016

wkentaro commented Mar 3, 2016

dirk-thomas commented Mar 3, 2016

wkentaro commented Mar 4, 2016

wkentaro commented Mar 4, 2016

dirk-thomas commented Mar 9, 2016

wkentaro commented Mar 9, 2016

dirk-thomas commented Mar 9, 2016

wkentaro commented Mar 9, 2016

dirk-thomas commented Mar 9, 2016

wkentaro commented Mar 9, 2016

dirk-thomas commented Mar 9, 2016

wkentaro commented Mar 9, 2016