Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosmaster allows multiple nodes with same xmlrpc uri but different path names #1662

Open
NickZ opened this issue Mar 16, 2019 · 1 comment
Open

Comments

@NickZ
Copy link

NickZ commented Mar 16, 2019

If multiple nodes have the same uri, but have different path names, rosmaster will allow the collision.

To test:

  1. I have created a branch on my fork of ros_comm to allow manually setting the XML-RPC server port in the roscpp client, here: https://github.com/NickZ/ros_comm/tree/test_xmlrpc_port
  2. Put my branch into a catkin workspace, along with the ros_tutorials, build it and source it.
  3. Run roscore
  4. Run rosrun roscpp_tutorials talker __xmlrpc_server_port:=22222 __name:="test1"
  5. In another terminal, find the PID of that node and kill -9 it, to prevent it from sending unpublish to the master
  6. rosnode list and confirm that /test1 is still in the rosnode list
  7. Run rosrun roscpp_tutorials talker __xmlrpc_server_port:=22222 __name:="test2"
  8. rosnode list and confirm that both /test1 and /test2 are still listed.
  9. rosnode info test1 and rosnode info test2 to confirm that both are listed as having the same XMLRPC uri and both are listed as connectable.
@fujitatomoya
Copy link
Contributor

fujitatomoya commented Mar 18, 2019

@NickZ

im just curious what if issue #4 instead of #7, it will fail to register cz same URI with same node?
and also curious to use cached parameter usecase since that will subscribe parameter with URI.

thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants