Fix exceptions if python is built without ipv6 support. #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admittedly a python bug, but the workaround is already present in other parts of this file.
|
Can one of the admins verify this patch? |
| if use_ipv6(): | ||
| reverse_ips = [host[4][0] for host in socket.getaddrinfo(socket.gethostname(), 0, 0, 0, socket.SOL_TCP)] | ||
| else: | ||
| reverse_ips = [host[4][0] for host in socket.getaddrinfo(socket.gethostname(), 0, socket.AF_INET, 0, socket.SOL_TCP)] |
There was a problem hiding this comment.
This is the same way as it is already used in other parts of the code (
). The change looks good - was probably just forgotten in the original patch for IPv6.…pport. A bit different than rosgraph fix because we do not have use_ipv6 here. See e.g. http://bugs.python.org/issue16208#msg178764
aballier
force-pushed
the
rosgraph_noipv6
branch
from
ed1b75b
to
afe5742
Compare
|
This change breaks a unit test: http://jenkins.ros.org/job/devel-indigo-ros_comm/125/ARCH_PARAM=amd64,UBUNTU_PARAM=trusty,label=devel/testReport/unit.test_roslaunch_launch/TestRoslaunchLaunch/test_validate_master_launch/ @aballier Why does you patch use And changed it back to use |
dirk-thomas
added a commit
that referenced
this pull request
Dec 10, 2014
mjyc
pushed a commit
to mjyc/ros_comm
that referenced
this pull request
Dec 10, 2014
* upstream/indigo-devel: fix regression of PR ros#515 Adding support for fixed-width floating-point and integer array values as per issue ros#400 Fix exception at roslaunch startup if python is build without ipv6 support. Fix exception at roscore startup if python has ipv6 disabled. use fileno comparison only as an alternative and when available fix removal of QueuedConnection leading to wrong subscriber count (fix ros#526) fix comment (fix ros#529) unregister statistics publisher Fix: TCPROS header validation crash when `callerid` header is not set avoid storing subscriber reference in SubscriberStatisticsLogger only create SubscriberStatisticsLogger when enabled make param functions thread-safe Do not use Python when building for Android Do not use ifaddrs on Android as it is not natively supported
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
* upstream/indigo-devel: fix regression of PR ros#515 Adding support for fixed-width floating-point and integer array values as per issue ros#400 Fix exception at roslaunch startup if python is build without ipv6 support. Fix exception at roscore startup if python has ipv6 disabled. use fileno comparison only as an alternative and when available fix removal of QueuedConnection leading to wrong subscriber count (fix ros#526) fix comment (fix ros#529) unregister statistics publisher Fix: TCPROS header validation crash when `callerid` header is not set avoid storing subscriber reference in SubscriberStatisticsLogger only create SubscriberStatisticsLogger when enabled make param functions thread-safe Do not use Python when building for Android Do not use ifaddrs on Android as it is not natively supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
http://bugs.python.org/issue16208
http://bugs.python.org/issue7735