Add more logging to publisher update calls. #979
Conversation
Because the publisher update calls are critical for setting up topic connections between subscribers and publishers, have added more detailed logging messages. The publishers are included so you know what the subscriber was told, as well as when the call succeeded or failed and if so why. The rosout topic is filtered out to reduce noise.
|
Filtering events for the rosout topics seems a bit arbitrary. I can appreciate that this could be noisy with every single node bringing up a rosout publisher, but I'm not sure it's worth it. |
|
@ros-pull-request-builder retest this please |
|
The rosout topic is "special" because every node automatically publishes to it and it's brought up automatically by the system, hence the special treatment. So I'd argue less arbitrary and more intentional. However I can agree that special treatment in code is not always desirable and after testing, I don't feel this buys us much in terms of data volume savings. I will remove it. |
|
I added the commit 34c57ac which moves some code to keep variables and comments closer to where they are used as well as reduce duplication. Since I only wrote the patch in the GitHub web interface it would be great if you could confirm that it still achieves your goal. |
|
@dirk-thomas Confirmed: output with commit 34c57ac achieves my goal. |
|
LGTM 👍 |
|
Thank you for the contribution. |
Because the publisher update calls are critical for setting
up topic connections between subscribers and publishers,
have added more detailed logging messages. The publishers
are included so you know what the subscriber was told, as
well as when the call succeeded or failed and if so why.
The rosout topic is filtered out to reduce noise.