Add Trigger service #5
Conversation
|
This looks like a reasonable message. However this should go in std_srvs not ros_comm_msgs. This one is used for internal testing and not recommended for users to use. |
|
Sorry, ignore my comment. I forgot std_srvs was in this repo. |
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| bool success # indicate successful run of triggered service | |||
| string message # informational, e.g. for error messages | |||
There was a problem hiding this comment.
Can you please add add a newline at the end of the file.
|
Can you also please update the wiki page to mention the new service (and probably rephrase the description of the other message as not being the only one anymore) and that it "was" added in Indigo. |
floweisshardt
force-pushed
the
indigo-devel
branch
from
f9afe6b
to
ca1cf8d
Compare
|
I added a newline at the end of the service definition and updated the wiki page to mention the new service under section 2. All other entries will be generated from the source update. |
|
+1 |
|
@dirk-thomas: are you planning to release that soon? We'd like to build our releases upon the new service. |
|
Since a release will require almost all ROS packages to be rebuild I try to group it with a set of other core repositories. So it might be a bit until I release it. But an upper bound should be two weeks because we will have "ROS 1 ticket squashing day" on April 2nd and will likely have several changes ready to be released afterwards. I hope that is fine for you. |
|
April 2nd is be perfect! Thanks |
|
@dirk-thomas: any update on an indigo release including std_srvs/Trigger? |
This service is of general purpose for triggering. Compared to the
Empty.srvit adds the possibility to check with the response if triggering was successful or not.