Use same QoS for all topic pub/subs #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
force-pushed
the
yadu/fix_qos_compatibility
branch
from
263459e
to
ed60f5d
Compare
ahcorde
requested changes
Jan 15, 2024
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Yadunund
commented
Jan 15, 2024
Co-authored-by: Yadu <yadunund@gmail.com>
ahcorde
approved these changes
Jan 15, 2024
|
Did CI get run on this PR? |
|
my bad, here we go:
|
|
I think CI is failing because the branch was deleted. I've triggered a rebuild after restoring the branch. |
|
Thank you @Yadunund, all good @clalancette |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all topic publishers and subscriptions are configured with the same QoS settings. Given that the history depth for the
turtle1/posesubscription was previously 1, I would observe thedraw_squareexecutable would sometimes wait indefinitely if the message was dropped. This could happen if the Default reliability is BEST_EFFORT instead of RELIABLE. With the changes, the reliability is RELIABLE and all pub/subs have compatible settings.