Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[teleop_turtle_key] update usage string to match keys captured by key… #165

Merged
merged 1 commit into from
May 6, 2024

Conversation

mikaelarguedas
Copy link
Member

…board

The keys actually captured in the code are the lowercase versions:

static constexpr char KEYCODE_B = 0x62;
static constexpr char KEYCODE_C = 0x63;
static constexpr char KEYCODE_D = 0x64;
static constexpr char KEYCODE_E = 0x65;
static constexpr char KEYCODE_F = 0x66;
static constexpr char KEYCODE_G = 0x67;
static constexpr char KEYCODE_Q = 0x71;
static constexpr char KEYCODE_R = 0x72;
static constexpr char KEYCODE_T = 0x74;
static constexpr char KEYCODE_V = 0x76;

On Windows it will still be the uppercase version but I suppose it is the case for case insensitive shells so this change in help string shouldn't impact the users

…board

On windows it will stay uppercase but shouldn't impact users compared to
current situation

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@ahcorde ahcorde merged commit e2853ca into rolling May 6, 2024
3 checks passed
@mikaelarguedas mikaelarguedas deleted the fix_usage_to_match_keys_in_code branch May 6, 2024 11:49
@ahcorde
Copy link

ahcorde commented May 6, 2024

https://github.com/Mergifyio backport jazzy

Copy link

mergify bot commented May 6, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 6, 2024
…board (#165)

On windows it will stay uppercase but shouldn't impact users compared to
current situation

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
(cherry picked from commit e2853ca)
ahcorde pushed a commit that referenced this pull request May 6, 2024
…board (#165) (#166)

On windows it will stay uppercase but shouldn't impact users compared to
current situation

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
(cherry picked from commit e2853ca)

Co-authored-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants