Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to clear buffer on resuming the buffer. Enables multiple… #26

Merged
merged 3 commits into from Aug 15, 2023

Conversation

DiuLaMaX
Copy link
Contributor

@DiuLaMaX DiuLaMaX commented Sep 1, 2022

… calls to write bags in a succession for different groupings in rosbag files

davidt315 and others added 2 commits September 1, 2022 12:01
… calls to write bags in a succession for different groupings in rosbag files
@davidt315
Copy link
Contributor

By default, the behavior of the package will remain the same where the topic that is being written from the buffer to a rosbag is cleared after writing. However, we found a use case where we could programmatically trigger snapshots for different cases e.g. navigation fails and we record a snapshot, or similarly the gps fails. In the case that multiple programmatic triggers call for snapshots and there is topic overlap, one rosbag would have all the data and since the buffer was cleared, the next rosbag snapshot for the next event shortly after would have no messages in the buffer.

We implemented a simple flag that can be configured with a launch file and uses the same user interaction to add the option to clear the buffer. Since the default is true - clear the buffer, others using the package would see no change and would continue to use the package without change.

@jahaniam
Copy link

jahaniam commented Aug 9, 2023

This is a very useful feature. Can we have this merged, please?

@DLu DLu merged commit 2f840c6 into ros:main Aug 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants