Comment out unused indent parameters #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
requested changes
Nov 2, 2016
| @@ -39,7 +39,7 @@ template<typename M> | |||
| struct Printer | |||
| { | |||
| template<typename Stream> | |||
| static void stream(Stream& s, const std::string& indent, const M& value) | |||
| static void stream(Stream& s, const std::string& /* indent */, const M& value) | |||
There was a problem hiding this comment.
Having the parameter name in the signature helps when looking at the API docs. Please add the following line at the beginning of the function body instead to make the variable not being unused anymore:
(void)indent
|
It seems I was able to retarget the PR without needing any changes on your branch. |
|
Thanks for the patch. |
dirk-thomas
approved these changes
Nov 2, 2016
dirk-thomas
pushed a commit
that referenced
this pull request
Feb 28, 2017
* Comment out unused indent parameters * Switched to use the void cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silences a clang warning.