-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment out unused indent parameters #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also rebase the patch against the latest branch kinetic-devel
.
@@ -39,7 +39,7 @@ template<typename M> | |||
struct Printer | |||
{ | |||
template<typename Stream> | |||
static void stream(Stream& s, const std::string& indent, const M& value) | |||
static void stream(Stream& s, const std::string& /* indent */, const M& value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the parameter name in the signature helps when looking at the API docs. Please add the following line at the beginning of the function body instead to make the variable not being unused anymore:
(void)indent
It seems I was able to retarget the PR without needing any changes on your branch. |
Thanks for the patch. |
* Comment out unused indent parameters * Switched to use the void cast.
Silences a clang warning.