fix for issue #77 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Mar 21, 2018
rostime/include/ros/impl/duration.h
Outdated
| @@ -56,7 +56,7 @@ namespace ros { | |||
| if (sec64 < INT_MIN || sec64 > INT_MAX) | |||
| throw std::runtime_error("Duration is out of dual 32-bit range"); | |||
| sec = (int32_t)sec64; | |||
| nsec = (int32_t)((d - (double)sec)*1000000000); | |||
| nsec = (int32_t)((d - (double)sec)*10000000000/10); | |||
There was a problem hiding this comment.
The approach to multiply it with an order of magnitude more and then divide again doesn't looks like a good approach.
Can you please try to use a rounding function (e.g. nearbyint) instead and confirm that it still addressed your problem.
There was a problem hiding this comment.
yes, nearbyint does the job.
There was a problem hiding this comment.
I updated the PR accordingly
This reverts commit 2ef78cd.
|
Thank you for the patch and for updating it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #77