add additional check for valid time values #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Jul 20, 2017
| @@ -108,11 +108,15 @@ namespace ros | |||
| #if HAS_CLOCK_GETTIME | |||
| timespec start; | |||
| clock_gettime(CLOCK_REALTIME, &start); | |||
| if (start.tv_sec < 0 || start.tv_sec > UINT_MAX) | |||
There was a problem hiding this comment.
Same as the other pr, might want to use UINT32_MAX:
There was a problem hiding this comment.
For reference: #61 (comment)
rostime/src/time.cpp
Outdated
| int64_t start_sec64 = start_li.QuadPart / 10000000; // 100-ns units | ||
| if (start_sec64 < 0 || start_sec64 > UINT_MAX) | ||
| throw std::runtime_error("SystemTime is out of dual 32-bit range"); | ||
| start_sec = (uint32_t)(start_sec64); |
There was a problem hiding this comment.
Indeed - and gone. Thanks.
dirk-thomas
force-pushed
the
rostime_check_time_sources
branch
from
58aac31
to
740b863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #60.
Adds additional checks around time source that the values are within the limits of the used data structures.
@ros/ros_team Please review.