Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy rosmake / rosdep is very slow #218

Closed
pirobot opened this issue Feb 9, 2013 · 5 comments
Closed

Groovy rosmake / rosdep is very slow #218

pirobot opened this issue Feb 9, 2013 · 5 comments

Comments

@pirobot
Copy link

pirobot commented Feb 9, 2013

After upgrading from Fuerte to Groovy (Debian packages under Ubuntu 12.04) I have found rosmake runs much slower than it used to. For example, for one of my typical stacks (http://ros-by-example.googlecode.com/svn/trunk/rbx_vol_1) which has 7 packages and mostly Python code, rosmake takes 7.9 seconds under Fuerte and 149 seconds (2 min 29 sec) under Groovy. That's 18x slower.

A posting on answers.ros.org (http://answers.ros.org/question/53925/rospack-became-agonizingly-slow/#53946) suggests that the problem is with rosdep2.

@roehling
Copy link
Contributor

The YAML parser seems to be the culprit: http://pyyaml.org/ticket/70
As Ubuntu ships with the optimized CLoader by default, I modified the cache loader accordingly: fkie-forks/rosdep@89a6848

However, even the "fast" loader introduces a noticeable delay to rospack when compared to Fuerte. A better solution would be to get rid of the repeated YAML parsing entirely and store the cache in a pre-parsed format that is optimized for fast loading. Maybe the source list can be serialized using Pickle or marshal?

@tfoote
Copy link
Member

tfoote commented Feb 20, 2013

b0aaeb0 in #222 provides a ~6x speedup for an empty package rosmake timing

@tfoote
Copy link
Member

tfoote commented Feb 20, 2013

The remaining time is mostly os.walk inside catkinpkg inst_pickle_updated

Closing and reopening as ros-infrastructure/catkin_pkg#33

@tfoote tfoote closed this as completed Feb 20, 2013
@jbohren
Copy link

jbohren commented Feb 20, 2013

@roehling
Copy link
Contributor

OS detection is time-consuming as well: ros-infrastructure/rospkg#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants