Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Indigo][moveit] Add/update metapackages. #13767

Closed
wants to merge 1 commit into from

Conversation

130s
Copy link
Member

@130s 130s commented Jan 31, 2017

  • Moving existing metapackages from an individual repo to moveit repo (for Indigo).
  • Adding a new metapackage (IJK).

Question: in both cases above, bloom has not yet been run (ie. release repo not updated). I'm afraid this PR would fail without those packages being bloomed? (If so I think I'll have to close this).

(Changes here is discussed in moveit/moveit_metapackages#11)

@130s
Copy link
Member Author

130s commented Feb 6, 2017

Closing. I assume moving packages to another repo still requires release artifact generated in the new release repo and that's why package.xml is not found for the moved packages. I'll bloom shortly.

@130s 130s closed this Feb 6, 2017
@130s 130s deleted the moveit/metapkg_update branch February 6, 2017 16:14
@130s 130s restored the moveit/metapkg_update branch February 6, 2017 22:27
@130s 130s changed the title [IJK][moveit] Add/update metapackages. [Indigo][moveit] Add/update metapackages. Feb 6, 2017
@130s
Copy link
Member Author

130s commented Feb 6, 2017

tldr; Please review. The change is for indigo only.

The packages listed in the change are already moved to a new devel repository, but bloom fails because they are already listed in rosdistro within the old repo. Therefore, in order to complete the move to a new devel repo, they need to be removed from rosdistro. Then bloom needs to be run shortly to keep the period where those packages in transition are not available as short as possible.

I removed the change from J and K, which can be done by bloom only (as already done for K #13809).

@dirk-thomas
Copy link
Member

What should be reviewed here? The ticket has been closed.

@wjwwood
Copy link
Member

wjwwood commented Feb 6, 2017

@130s this pr is closed?

@130s
Copy link
Member Author

130s commented Feb 6, 2017

Reopen button is disabled so that I can't reopen. Maybe I'll just open a new PR instead of digging further for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants