Revert "Add junit-xml rules (both distribution-wise and PIP)" #14208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
approved these changes
Mar 18, 2017
|
I agree with #14161 (comment) and create a key for junit.xml only on recent distros |
|
@jvgomez Could you make an updated PR with the changes mentioned by @mikaelarguedas assuming that works for your use case. (Since you were using that before anyway that seems like it should work.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14161
As per the discussion in #14161 this is an inconsistent state bringing in two different libraries, junitxml and juint_xml are different. I'd like to revert this and make sure we have a a single library.