Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eigenpy: 1.5.0-0 in 'kinetic/distribution.yaml' [bloom] #20115

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

wxmerkt
Copy link
Contributor

@wxmerkt wxmerkt commented Jan 30, 2019

Increasing version of package(s) in repository eigenpy to 1.5.0-0:

@tfoote
Copy link
Member

tfoote commented Jan 31, 2019

This looks fine. I'm going to merge it, but we highly recommend at least a source entry so people can easily check it out from source into a workspace using rosinstall_generator or other automated tools from the rosdistro. And a doc entry is good if there's any API documentation available in the package that can be rendered onto the website. Info on indexing can be found here Please consider a follow up PR to add the source and doc entries. You can do it manually or bloom can do it automatically if you say yes to the prompts.

@tfoote tfoote merged commit a66a989 into ros:master Jan 31, 2019
@wxmerkt
Copy link
Contributor Author

wxmerkt commented Feb 1, 2019

Thank you for the pointer @tfoote. We will do this in a follow-up/new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants