Add ifcfg-pip #22071
Add ifcfg-pip #22071
Conversation
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
waiting for rosdistro PR approval ros/rosdistro#22071
|
working on a |
| @@ -154,6 +154,19 @@ gunicorn: | |||
| fedora: [python-gunicorn] | |||
| gentoo: [www-servers/gunicorn] | |||
| ubuntu: [gunicorn] | |||
| ifcfg-pip: | |||
There was a problem hiding this comment.
Since we're using this for ROS 2 we'll want the key name for the platform installer to be python3-ifcfg. I think this key name is fine for pip. An alternative might be python3-ifcfg-pip but since the pip key is not python3 specific I don't feel a preference for it.
I like explicit vendor packages rather than packaging things off the farm and importing them as we do for opensplice and lark-parser but let's check in with some other folks tomorrow to decide what to do for ifcfg. I have also added this to my big list of things to try and get upstreamed into Debian for future ROS 2 releases. |
* add network checks and report Signed-off-by: claireyywang <clairewang@openrobotics.org> * network shenanigens Signed-off-by: claireyywang <clairewang@openrobotics.org> * network shenanigens Signed-off-by: claireyywang <clairewang@openrobotics.org> * network shenanigens Signed-off-by: claireyywang <clairewang@openrobotics.org> * add network check and report Signed-off-by: claireyywang <clairewang@openrobotics.org> * update code format Signed-off-by: claireyywang <clairewang@openrobotics.org> * revised code format Signed-off-by: claireyywang <clairewang@openrobotics.org> * add ifcfg-pip rosdep key waiting for rosdistro PR approval ros/rosdistro#22071 * added rosdep key ifcfg-pip Signed-off-by: claireyywang <clairewang@openrobotics.org> * revise code Signed-off-by: claireyywang <clairewang@openrobotics.org>
There was a problem hiding this comment.
If we want this to be a core tool dependency I think that using a vendor package is better than using pip, because we can't use pip as a core dependency when we're packaging.
And if we're going to vendor it then we I think it's better not to have conflicting pip rules for it.
|
Closing as a |
This package is used in ros2doctor network feature to check network configuration.
Package repo can be found at https://github.com/ftao/python-ifcfg, and it is compatible with Python2 and Python3.
Web index: https://pypi.org/project/ifcfg/, no platform specific package index found.
Explicit vendor package can be found at https://github.com/ros2/ifcfg_vendor