Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warehouse_ros: 0.9.5-1 in 'noetic/distribution.yaml' [bloom] #33124

Closed
wants to merge 1 commit into from

Conversation

rhaschke
Copy link
Contributor

Increasing version of package(s) in repository warehouse_ros to 0.9.5-1:

warehouse_ros

* Drop compile option -std=c++11 (C++11 or later is default anyway) (#92 <https://github.com/ros-planning/warehouse_ros/issues/92>)
* Remove user-provided constructors and destructors (#51 <https://github.com/ros-planning/warehouse_ros/issues/51>)
  ``ResultIterator::metadata_only_`` is now non-const to allow moving and assigning
* Add virtual destructor to ``MessageCollectionHelper`` and ``ResultIteratorHelper`` (#50 <https://github.com/ros-planning/warehouse_ros/issues/50>)
* Contributors: Bjar Ne, Jochen Sprickerhof

@github-actions github-actions bot added the noetic Issue/PR is for the ROS 1 Noetic distribution label May 10, 2022
@methylDragon methylDragon added the changes requested Maintainers have asked for changes to the pull request label May 10, 2022
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! I know you have a license file on the ros2 branch, but you might want to put it on the branch listed in the source entry since we require license files

(:

@rhaschke
Copy link
Contributor Author

Sure, will do.

@rhaschke rhaschke closed this May 10, 2022
@rhaschke rhaschke deleted the bloom-warehouse_ros-1 branch September 20, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request noetic Issue/PR is for the ROS 1 Noetic distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants