Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rplidar_ros: 2.1.3-3 in 'humble/distribution.yaml' [bloom] #38049

Merged
merged 2 commits into from
Jul 24, 2023
Merged

rplidar_ros: 2.1.3-3 in 'humble/distribution.yaml' [bloom] #38049

merged 2 commits into from
Jul 24, 2023

Conversation

deyouslamtec
Copy link
Contributor

Increasing version of package(s) in repository rplidar_ros to 2.1.3-3:

rplidar_ros

* Bugfix:auto standby mode not work
* Rename SLLidar* to RPLidar* in rplidar_node.cpp
* Renaming variable m_running to is_scanning
* Update README
* Use rplidar_ros.rviz instead of rplidar.rviz
* Update source files in src directory:
  Use the source files developed by Slamtec instead of the old ones, and add the functionality of the old code.
* Modify and add launch files
* Update rplidar-sdk to 2.0.0
* Update create_udev_rules.sh
* Update description in package.xml
* Update maintainer to Wang DeYou
* Contributors: Wang DeYou

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Jul 20, 2023
@deyouslamtec
Copy link
Contributor Author

Close #37679

@quarkytale quarkytale added the held for sync Issue/PR has been held because the distribution is in a sync hold label Jul 20, 2023
@emersonknapp
Copy link
Contributor

Holding for an upcoming Humble sync

emersonknapp
emersonknapp requested changes Jul 20, 2023
View reviewed changes
humble/distribution.yaml
@@ -6128,11 +6128,15 @@ repositories:
version: master
status: maintained
rplidar_ros:
doc:
type: git
url: https://github.com/Slamtec/rplidar_ros.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that this URL is different than the source URL. These should ideally be the same, is there a strong reason to keep them different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source URL should be changed to https://github.com/Slamtec/rplidar_ros.git. I close this PR and re-apply for PR after modification, is that okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you made the change, thank you! Will you also be changing Iron and Rolling?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will change them in the future

emersonknapp
emersonknapp approved these changes Jul 21, 2023
View reviewed changes
humble/distribution.yaml
@@ -6128,11 +6128,15 @@ repositories:
version: master
status: maintained
rplidar_ros:
doc:
type: git
url: https://github.com/Slamtec/rplidar_ros.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you made the change, thank you! Will you also be changing Iron and Rolling?

@audrow audrow merged commit 4700964 into ros:master Jul 24, 2023
4 checks passed
@deyouslamtec deyouslamtec mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@audrow audrow audrow approved these changes

Assignees
No one assigned
Labels
held for sync Issue/PR has been held because the distribution is in a sync hold humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deyouslamtec @emersonknapp @audrow @quarkytale