Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry2: 0.31.7-1 in 'iron/distribution.yaml' [bloom] #41384

Merged
merged 1 commit into from
May 30, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 29, 2024

Increasing version of package(s) in repository geometry2 to 0.31.7-1:

examples_tf2_py

  • No changes

geometry2

  • No changes

tf2

* [TimeCache] Improve performance for insertData() and pruneList() (backport #680 <https://github.com/ros2/geometry2/issues/680>) (#694 <https://github.com/ros2/geometry2/issues/694>)
  * Nacho/minor fixes tf2 cache (#658 <https://github.com/ros2/geometry2/issues/658>)
  * Remove unused parameter
  * Make use of API function to improve redability
  ```cpp
  TimePoint TimeCache::getLatestTimestamp()
  {
  return storage\_.front().stamp\_;
  }

And std::list::front() is(gcclib):

reference
front() _GLIBCXX_NOEXCEPT
{ return *begin(); }
  • Same argument as 321bd225afb5c
TimePoint TimeCache::getLatestTimestamp()
{
// empty list case
// ...
return storage\_.front().stamp\_;
}

and std::list::front():

reference
front() _GLIBCXX_NOEXCEPT
{ return *begin(); }
  • Improve readbility by relying on STL functions
    By now reading to this block I can tell that we are preventing to
    inserting a new element in the list, that has a timestamp that is
    actually older than the max_storage_time_ we allow for
  • Remove hardcoded algorithmg for STL one
    The intent of the code is now more clear, instead of relying on raw
    loops, we "find if" there is any element in the list that has a stamp
    older than the incoming one. With this we find the position in the list
    where we should insert the current timestamp: storage_it
  • Remove to better express what this pointer is represetngin
  • Replace raw loop for STL algorithm
    Remove if any element is older thant the max_storage_time_ allowed,
    relative to the latest(sooner) time seems clear npw
  • [TimeCache] Improve performance for insertData() and pruneList() (announce hydro alpha #680 [TimeCache] Improve performance for insertData() and pruneList() ros2/geometry2#680)
    Co-authored-by: Chris Lalancette mailto:clalancette@gmail.com
  • Don't break ABI

Co-authored-by: Ignacio Vizzo mailto:ignacio@dexory.com
Co-authored-by: Eric Cousineau mailto:eric.cousineau@tri.global
Co-authored-by: Chris Lalancette mailto:clalancette@gmail.com
Co-authored-by: Alejandro Hernández Cordero mailto:ahcorde@gmail.com


## tf2_bullet

- No changes

## tf2_eigen

- No changes

## tf2_eigen_kdl

- No changes

## tf2_geometry_msgs

- No changes

## tf2_kdl

- No changes

## tf2_msgs

- No changes

## tf2_py

- No changes

## tf2_ros

- No changes

## tf2_ros_py

- No changes

## tf2_sensor_msgs

- No changes

## tf2_tools

- No changes

@github-actions github-actions bot added the iron Issue/PR is for the ROS 2 Iron distribution label May 29, 2024
@nuclearsandwich nuclearsandwich merged commit 0e6aa27 into ros:master May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iron Issue/PR is for the ROS 2 Iron distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants