Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for universal and ball joint in sdf #13

Merged
merged 10 commits into from
Jun 20, 2022
Merged

Support for universal and ball joint in sdf #13

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c25c7c6
universal/ball -> floating joints
quarkytale Jun 7, 2022
64ce17d
Merge branch 'ros2' into quarkytale/joint_support
quarkytale Jun 13, 2022
5050350
suggested changes
quarkytale Jun 13, 2022
6140c00
added joint tests
quarkytale Jun 16, 2022
549a963
fixed tests
quarkytale Jun 17, 2022
6c17e8a
cleaning
quarkytale Jun 17, 2022
a2b3dc3
check for joint axis and added test
quarkytale Jun 17, 2022
8f1f206
newline
quarkytale Jun 17, 2022
5b2fdf7
updating CMakeLists
quarkytale Jun 17, 2022
b69f03c
missing space
quarkytale Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sdformat_urdf/src/sdformat_urdf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,12 +494,14 @@ sdformat_urdf::convert_joint(const sdf::Joint & sdf_joint, sdf::Errors & errors)
case sdf::JointType::PRISMATIC:
urdf_joint->type = urdf::Joint::PRISMATIC;
break;
case sdf::JointType::INVALID: // Unsupported: fall through to default
case sdf::JointType::BALL: // |
case sdf::JointType::UNIVERSAL: // Unsupported: fall through to floating
case sdf::JointType::BALL: // Will require custom TF publisher
case sdf::JointType::GEARBOX: // |
quarkytale marked this conversation as resolved.
Show resolved Hide resolved
case sdf::JointType::REVOLUTE2: // |
case sdf::JointType::SCREW: // |
case sdf::JointType::UNIVERSAL: // V
case sdf::JointType::SCREW: // V
urdf_joint->type = urdf::Joint::FLOATING;
break;
case sdf::JointType::INVALID:
default:
errors.emplace_back(
sdf::ErrorCode::STRING_READ,
Expand Down