Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebasing Commits from ROS 1 Branch #51

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Rebasing Commits from ROS 1 Branch #51

merged 3 commits into from
Oct 14, 2021

Conversation

DLu
Copy link
Collaborator

@DLu DLu commented Oct 5, 2021

Cherry pick PRs #47 and #48 to ROS 2.

@DLu DLu requested a review from hidmic October 5, 2021 18:16
README.md Show resolved Hide resolved
@DLu DLu requested a review from hidmic October 13, 2021 13:21
Copy link

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DLu would you mind updating this PR title to squash-merge or cleaning up commits to rebase-merge? I don't mind either way.

@DLu DLu changed the title Sync Rebasing Commits from ROS 1 Branch Oct 14, 2021
@DLu
Copy link
Collaborator Author

DLu commented Oct 14, 2021

How's that?

@hidmic hidmic merged commit 09a5289 into ros2 Oct 14, 2021
@hidmic hidmic deleted the sync branch October 14, 2021 14:52
@hidmic
Copy link

hidmic commented Oct 14, 2021

@DLu I went ahead and signed it off for you. I hope you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants