Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github pages with rustdoc documentation #275

Open
nnmm opened this issue Oct 3, 2022 · 5 comments
Open

Create github pages with rustdoc documentation #275

nnmm opened this issue Oct 3, 2022 · 5 comments

Comments

@nnmm
Copy link
Contributor

nnmm commented Oct 3, 2022

docs.rs cannot build rclrs since it requires a ROS 2 installation, and as such it can't display the rustdocs: https://docs.rs/crate/rclrs/0.2.0

To make ros2-rust more accessible, we should host the docs ourselves, and GitHub pages are probably the easiest way. They could be updated in a CI step.

Crates that should be covered are rclrs, rosidl_runtime_rs, and perhaps generated message crates for common_interfaces packages (they are built in CI anyway).

@esteve
Copy link
Collaborator

esteve commented Oct 3, 2022

I agree, though I'd use readthedocs to host the documentation, a significant number of open source projects host their documentation there. I'd leave Github pages for non-documentation content.

@nnmm
Copy link
Contributor Author

nnmm commented Oct 3, 2022

Can you upload rustdoc-generated html to readthedocs? I think readthedocs is linked to Sphinx. I couldn't find an example of Rust documentation on readthedocs either.

@michalfita
Copy link

@nnmm
Copy link
Contributor Author

nnmm commented Feb 10, 2023

@michalfita Unfortunately, ROS 2 is not in the standard Ubuntu 20.04 repositories.

@michalfita
Copy link

It may be tough call, but for ros2-rust to go mainstream docs.rs is mandatory. Either raise good cause and reason and reqest adding ROS2 to their Docker
or
Fork it with required dependencies and run own copy... Question remains open where to host it.

That BTW sounds like a feature to allow certain serious maintainers to provide own Docker image to generate documentation 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants