-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isolated gmock test #4
Conversation
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
…ator self-test Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
See comment on #3 (comment). |
@dirk-thomas Yeah - if you're OK with moving everything into ament_cmake_ros, I'm happy to do it. Is the assumption that if you're using ament_cmake_ros, you already deep enough into the dependency graph that it's safe to add both ament_cmake_pytest and ament_cmake_gtest even if you only plan on using one of them? |
Yeah, that would be my thinking. @wjwwood Since you merged this what do you think about reintegrating these into |
That’s fine with me. |
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
fba2d2d
to
4352af2
Compare
@dirk-thomas Ok - I've mashed everything into ament_cmake_ros now, too. Tested with isolated tests in rcl (gtest) rclpy (pytest) and rosbag2 (gmock) The dependency graph of ament_cmake_ros used to look like this:
After this PR it will look like this:
|
@wjwwood I think this is good to go |
…cmake_ros Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
Looks like there are some linting issues that need to be resolved. |
sigh on it! |
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
While trying to isolated the rosbag2 tests, I noticed two things:
Fix 1 by adding ament_cmake_ros_isolated_gmock (depends on this PR)
Fix 2 by having the tests for the domain coordinator run using a different set of ports.