Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lifecycle] installed python files are not executable #100

Closed
wjwwood opened this issue Dec 19, 2016 · 5 comments
Closed

[lifecycle] installed python files are not executable #100

wjwwood opened this issue Dec 19, 2016 · 5 comments
Assignees

Comments

@wjwwood
Copy link
Member

wjwwood commented Dec 19, 2016

They are in bin, but not executable and so which doesn't find them:

% which lifecycle_listener
/tmp/testing_beta1/ros2-osx/bin/lifecycle_listener
% which lifecycle_demo_launch.py
lifecycle_demo_launch.py not found

However, this is how the user is recommended to execute them:

python3 `which lifecycle_service_client_py.py`

-- https://github.com/ros2/ros2/wiki/Managed-Nodes

Not sure if this works on Linux as-is, but it doesn't work with zsh on OS X (my machine).

@dirk-thomas
Copy link
Member

The file is executable when building from source. But it doesn't have a shebang line. Therefore the instructions worked for me. But this should certainly be fixed.

@Karsten1987
Copy link
Contributor

Karsten1987 commented Dec 19, 2016

Oh, I am sorry. Didn't know that.
So I'll update my python script with:

#!/usr/bin/env python

Is that correct? Interestingly, all python demos don't have the shebang either. Should that be corrected then as well? Or is the solution to add the +x flag?

@dirk-thomas
Copy link
Member

Can you point to the specific case you are referring to. At least some are being installed as console_scripts from the setup.py file which will take care of that.

@dirk-thomas
Copy link
Member

Is anyone working on a fix for this?

@dirk-thomas dirk-thomas self-assigned this Dec 19, 2016
@dirk-thomas dirk-thomas added the in progress Actively being worked on (Kanban column) label Dec 19, 2016
@dirk-thomas
Copy link
Member

I created #101. Can one of you please confirm that it fixes the problem for you, too.

@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 19, 2016
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants