Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine demo_nodes_cpp source codes #269

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Refine demo_nodes_cpp source codes #269

merged 2 commits into from
Jul 11, 2018

Conversation

youtalk
Copy link
Contributor

@youtalk youtalk commented Jul 11, 2018

This PR refines demo_nodes_cpp source codes below:

  • 53da24a: Use AddTwoInts namespace for readability.
  • ef6ed16: Fix class name typo (which I think so).

There is no problem to call the following commands.

$ ros2 run demo_nodes_cpp reuse_timer
$ ros2 launch demo_nodes_cpp add_two_ints.launch.py

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 11, 2018
@wjwwood
Copy link
Member

wjwwood commented Jul 11, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit 4e3f5eb into ros2:master Jul 11, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jul 11, 2018
@youtalk youtalk deleted the refine-demo-nodes-cpp branch July 11, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@youtalk @wjwwood @dirk-thomas