Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependency on ros2run #413

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Nov 5, 2019

Precisely what the title says.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@dirk-thomas
Copy link
Member

In order to remove the dependency you must also remove its usage from here:

from ros2run.api import run_executable

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Nov 5, 2019

Argh, I had not seen that use. Brought back in 1665dbc.

@hidmic
Copy link
Contributor Author

hidmic commented Nov 5, 2019

Sanity CI for lifecycle and dummy_robot_bringup demo packages:

  • Linux Build Status

@dirk-thomas
Copy link
Member

I though the goal was to remove all dependencies on the ros2cli repo?

@hidmic
Copy link
Contributor Author

hidmic commented Nov 5, 2019

I though the goal was to remove all dependencies on the ros2cli repo?

We would have to get rid of the ros_testing -> ros2test -> ros2cli chain of dependencies, so it doesn't seem possible (unless we re-discuss that as well). Anyways, unnecessary dependencies can still go away.

@hidmic hidmic merged commit 404c8ab into master Nov 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/cleanup-demo-deps branch November 5, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants