change ParameterEventHandler to take events as const ref instead of shared pointer #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hared pointer Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Audrow Nash <audrow@hey.com>
This was referenced Apr 2, 2021
wjwwood
commented
Apr 2, 2021
Signed-off-by: Audrow Nash <audrow@hey.com>
|
Yes, probably need to update the ROS2 tutorial for the ParameterEventHandler. I'll take a look. |
mjeronimo
approved these changes
Apr 2, 2021
|
As it turns out the ParameterEventHandler tutorial doesn't need to be updated as it doesn't use the add_parameter_event_handler() method (which is the one use to monitor all parameter events); instead, it uses add_parameter_handler(), which is unaffected by the change from the client code point of view. So, the changes in the #494 and ros2/rclcpp#1598 are sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to, and requires, ros2/rclcpp#1598
@mjeronimo can you think of any other places we need to update something like this? Documentation?