change how serialized message works with subscription #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodall <william@osrfoundation.org>
5 tasks
audrow
approved these changes
Apr 13, 2021
|
Here's CI (green): ros2/rclcpp#1557 (comment) |
ivanpauno
reviewed
Jun 8, 2021
| @@ -70,7 +70,7 @@ class SerializedMessageListener : public rclcpp::Node | |||
| } | |||
|
|
|||
| private: | |||
| rclcpp::Subscription<rclcpp::SerializedMessage>::SharedPtr sub_; | |||
| rclcpp::Subscription<std_msgs::msg::String>::SharedPtr sub_; | |||
There was a problem hiding this comment.
I think it's worth to add a note in the release notes about this API change: https://github.com/ros2/ros2_documentation/blob/rolling/source/Releases/Release-Humble-Hawksbill.rst
There was a problem hiding this comment.
I agree, at the time we were waiting on that page to be created. @audrow does it make sense to add it there now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rclcpp#1557