Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README's for action_tutorials. #576

Merged
merged 13 commits into from
Dec 7, 2022
Merged

Add README's for action_tutorials. #576

merged 13 commits into from
Dec 7, 2022

Conversation

kagibson
Copy link
Contributor

Signed-off-by: Kurtis Gibson kurtisgibsonmusic@gmail.com

@kagibson kagibson mentioned this pull request Jul 26, 2022
@kagibson
Copy link
Contributor Author

@audrow

@audrow audrow self-requested a review July 27, 2022 17:21
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good. I have a few formatting changes that should be applied throughout the READMEs.

action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
action_tutorials/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
@audrow audrow self-assigned this Jul 27, 2022
@kagibson kagibson force-pushed the rolling branch 4 times, most recently from 605f8db to f2b82e2 Compare July 27, 2022 19:17
@kagibson kagibson requested a review from audrow July 28, 2022 14:45
Copy link
Contributor Author

@kagibson kagibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made updates based on the changes you've requested. Thanks @audrow !

Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. There's a few small changes to be made.

action_tutorials/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_interfaces/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_py/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_py/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_py/README.md Outdated Show resolved Hide resolved
@kagibson kagibson requested a review from audrow November 10, 2022 17:57
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iteration @kagibson! I've given some feedback. It's looking better.

action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
action_tutorials/README.md Outdated Show resolved Hide resolved
action_tutorials/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_interfaces/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_interfaces/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_py/README.md Outdated Show resolved Hide resolved
action_tutorials/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
action_tutorials/action_tutorials_cpp/README.md Outdated Show resolved Hide resolved
kagibson and others added 11 commits December 3, 2022 18:56
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Add Oxford comma

Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Fix spacing on if statement

Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Fix spacing on std::thread

Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Add newlines

Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
@kagibson kagibson requested review from mjeronimo and audrow and removed request for adityapande-1995 and mjeronimo December 4, 2022 03:47
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Copy link
Contributor

@mjeronimo mjeronimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once Audrow is good, we can merge.

Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks, @kagibson!

@audrow
Copy link
Member

audrow commented Dec 7, 2022

I'm going to merge this in without running CI since it only touches README files and the PR jobs are happy.

@audrow audrow merged commit c212741 into ros2:rolling Dec 7, 2022
cardboardcode pushed a commit to cardboardcode/demos that referenced this pull request Jan 23, 2023
Co-authored-by: Audrow Nash <audrow@hey.com>
cardboardcode pushed a commit to cardboardcode/demos that referenced this pull request Jan 23, 2023
Co-authored-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants