-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README's for action_tutorials. #576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good. I have a few formatting changes that should be applied throughout the READMEs.
605f8db
to
f2b82e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made updates based on the changes you've requested. Thanks @audrow !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. There's a few small changes to be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the iteration @kagibson! I've given some feedback. It's looking better.
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Add Oxford comma Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Fix spacing on if statement Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Fix spacing on std::thread Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Add newlines Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
Signed-off-by: kagibson <kurtisgibsonmusic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once Audrow is good, we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks, @kagibson!
I'm going to merge this in without running CI since it only touches README files and the PR jobs are happy. |
Co-authored-by: Audrow Nash <audrow@hey.com>
Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Kurtis Gibson kurtisgibsonmusic@gmail.com