Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy nodes when the example is done #196

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Destroy nodes when the example is done #196

merged 1 commit into from
Dec 6, 2017

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Dec 6, 2017 •
edited
Loading

Destroys nodes when the user sends SIGINT.

CI linux only on examples_rclpy_executors since this is a leaf package with no tests besides linters
http://ci.ros2.org/job/ci_linux/3760 (passed)

connects to #193

@sloretz sloretz added the in review Waiting for review (Kanban column) label Dec 6, 2017
@sloretz sloretz self-assigned this Dec 6, 2017
dirk-thomas
dirk-thomas approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it with one of them and it works for me.

@sloretz sloretz merged commit 4218a76 into master Dec 6, 2017
@sloretz sloretz deleted the destroy_python_nodes branch December 6, 2017 20:13
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Dec 6, 2017
@sloretz sloretz mentioned this pull request Dec 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @dirk-thomas