Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topic Statistics Example #281

Merged
merged 3 commits into from
Jul 22, 2020

Conversation

dabonnie
Copy link
Contributor

@dabonnie dabonnie commented Jul 17, 2020

Adds an example subscriber which enables topic statistics and illustrates some of the configuration options.

Related to ros2/ros2_documentation#824, https://github.com/ros-tooling/aws-roadmap/issues/246

Signed-off-by: Devin Bonnie dbbonnie@amazon.com

Fix linting errors

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@dabonnie
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dabonnie
Copy link
Contributor Author

PTAL @jacobperron @hidmic

@dabonnie
Copy link
Contributor Author

@jacobperron @hidmic friendly ping :-)

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@dabonnie dabonnie force-pushed the dabonnie/topic-stats-example branch from 10de0dc to 981f86c Compare July 20, 2020 22:25
@dabonnie
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows [Build Status]

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the uncrustify error. (I think the PR CI job should be enough, no need to rerun CI on all platforms).

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobperron jacobperron merged commit e7477f1 into ros2:master Jul 22, 2020
@dabonnie dabonnie deleted the dabonnie/topic-stats-example branch July 22, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants